Re: [PATCH v5 02/15] rust: sync: completion: add wait_for_completion_timeout()
From: John Hubbard
Date: Fri Oct 02 2026 - 05:19:20 EST
On 10/2/26 10:21 AM, Alice Ryhl wrote:
On Wed, Sep 30, 2026 at 5:43 AM John Hubbard <jhubbard@xxxxxxxxxx> wrote:
From: Joel Fernandes <joelagnelf@xxxxxxxxxx>
A driver that runs an interrupt self-test during probe waits for the
handler to fire. wait_for_completion() has no timeout, so a broken
interrupt path stalls probe indefinitely. Add a timeout variant of
wait_for_completion().
Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
Signed-off-by: Joel Fernandes <joelagnelf@xxxxxxxxxx>
[jhubbard: return the remaining jiffies]
Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
With the timeout clamped to LONG_MAX as sashiko says:
Clearly Sashiko is improving its Rust-for-Linux review capabilities.
It missed this on the first four revisions of the series, but now
it spotted it. Progress!>
Acked-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
Feel free to take through drm-rust-next.
Thanks for the review, Alice!
thanks,
--
John Hubbard