Re: [PATCH v4 1/1] braille: nbcon: Allow to use a serial console with NBCON API as Braille console
From: John Ogness
Date: Fri Oct 02 2026 - 05:24:39 EST
On 2026-10-02, Petr Mladek <pmladek@xxxxxxxx> wrote:
> It should be good enough for 7.3. And I wanted to get it into
> linux-next ASAP.
>
> There is still an open problem with the dependency on CONFIG_PRINTK
> to fix the Sashiko complains. We might add it as a separate patch.
> But we might also try to fix it properly by enabling nbcon.c code
> even when CONFIG_PRINTK is disabled, ...
It would probably be enough just to set the !CONFIG_PRINTK case to:
static inline bool nbcon_braille_try_acquire(struct console *con,
struct nbcon_write_context *wctxt) { return true; }
Since there is no PRINTK, there will be no consoles to synchronize
against.
Or in drivers/accessibility/braille/braille_console.c you could change
all the
panic_on_this_cpu()
checks to
IS_ENABLED(CONFIG_PRINTK) && panic_on_this_cpu()
John