Re: [PATCH] usb: dwc3: meson-g12a: disable VBUS regulator on remove

From: gregkh@xxxxxxxxxxxxxxxxxxx

Date: Fri Oct 02 2026 - 05:29:43 EST


On Fri, Oct 02, 2026 at 03:18:38AM +0000, Thinh Nguyen wrote:
> On Thu, Sep 24, 2026, Guangshuo Li wrote:
> > dwc3_meson_g12a_probe() enables priv->vbus when the optional regulator is
> > present, but dwc3_meson_g12a_remove() does not perform the matching
> > regulator_disable(). The probe error path already disables the regulator
> > before rearming the reset control.
> >
> > Disable priv->vbus in the remove path before reset_control_rearm() to
> > match the cleanup performed by the probe error path.
> >
> > Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue")
>
> We should also include Cc stable.

Maybe if the sashiko results are fixed first, this is dropped from my
review queue.

thanks,

greg k-h