Re: [PATCH v3 5/7] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add SDM632

[Krzysztof Kozlowski]

On Fri, Oct 02, 2026 at 12:38:33AM +0200, Barnabás Czémán wrote:
> SDM632 MSS is very similar for MSM8953 mss the difference is
> mss-supply is a pm domain on SDM632, previously SDM632 MSS
> was represented by MSM8953 MSS. Correct the bindings to
> described it correctly.
> 
> Signed-off-by: Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml     | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
> index 4049157dd83d..049191cad5f8 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
> @@ -27,6 +27,7 @@ properties:
>            - qcom,msm8940-mss-pil
>            - qcom,msm8953-mss-pil
>            - qcom,msm8974-mss-pil
> +          - qcom,sdm632-mss-pil
>  
>        - const: qcom,q6v5-pil
>          description: Deprecated, prefer using qcom,msm8916-mss-pil
> @@ -79,14 +80,14 @@ properties:
>                       (not valid for qcom,msm8226-mss-pil, qcom,msm8926-mss-pil
>                       and qcom,msm8974-mss-pil)
>        - description: MSS proxy power domain (control handed over after startup)
> -                     (only valid for qcom,msm8953-mss-pil)
> +                     (only valid for qcom,sdm632-mss-pil)
>      minItems: 1
>  
>    power-domain-names:
>      items:
>        - const: cx
>        - const: mx # not valid for qcom,msm8226-mss-pil, qcom-msm8926-mss-pil and qcom,msm8974-mss-pil
> -      - const: mss # only valid for qcom,msm8953-mss-pil
> +      - const: mss # only valid for qcom,sdm632-mss-pil

So not valid for msm8953, but msm8953 has it, so you just introduced new
warnings, no?

Anyway, changing existing device needs its own rationale and usually own
commit.

Best regards,
Krzysztof