Re: [PATCH 2/2] iio: imu: Add driver for the ADI ADIS16607

[Nuno Sá]

On Fri, Oct 02, 2026 at 01:38:36PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 01, 2026 at 12:11:50PM +0300, Radu Sabau via B4 Relay wrote:
> 
> > The ADIS16607 is a Precision MEMS IMU from Analog Devices featuring
> > triaxial gyroscope, triaxial accelerometer, delta angle, delta velocity,
> > and temperature channels. The device communicates over SPI Half-Duplex,
> > requiring custom read and write ops that differ from the standard ADIS
> > library protocol.
> > 
> > Three variants are supported:
> >   - ADIS16607-1: ±125°/s gyroscope range
> >   - ADIS16607-2: ±450°/s gyroscope range
> >   - ADIS16607-3: ±2000°/s gyroscope range
> > 
> > All variants share a ±40g accelerometer range and an 8 kHz internal
> > clock.
> > 
> > Data is acquired via 32-bit burst reads over a single held-low CS
> > transfer, providing 24-bit real resolution for all inertial channels.
> > 
> > Supported features:
> >   - Hardware FIFO mode with configurable watermark threshold
> >   - External clock with direct and scaled synchronization modes
> >   - Calibration bias for gyroscope and accelerometer axes
> >   - Configurable data-ready interrupt pin (DIO1-4)
> >   - Optional hardware reset via GPIO
> >   - Sensor self-test on probe
> >   - Sampling frequency control via decimation rate register
> >   - DebugFS entries for serial number, device ID, firmware and revision IDs
> 
> Good, now split this to be a series of 5, for example.

On of that I see that the driver is skipping adislib helpers like
locking, startup, self tests. First consider and think on how the lib
can be improved, changed in order to accommodate this device. The less
code we duplicate, the better.

- Nuno Sá

> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>