Re: [PATCH v4 09/13] mm/collapse: separate scanning a PTE table from collapsing it

From: Kiryl Shutsemau

Date: Fri Oct 02 2026 - 07:16:15 EST


On Thu, Oct 01, 2026 at 10:34:54AM +0200, David Hildenbrand (Arm) wrote:
> So I suggest the following in the context of this patch here:
>
> collapse_scan_pmd
> -> collapse_scan_file
> -> collapse_scan_anon
>
> collapse_pmd
> -> collapse_anon
> -> collapse_file


Fine with me.

collapse_file() has been using collapse as the verb all along, so my
namespace argument was not much of one.

> You should mention that collapse_single_pmd() is only temporary.

Will do.

> I'd just not add that doc if you intend to remove the whole thing in the same
> comment.

Ack.

--
Kiryl Shutsemau / Kirill A. Shutemov