Re: [PATCH v4 2/2] nvme-multipath: add fail_if_no_path sysfs attribute

From: Krishna Iyer

Date: Fri Oct 02 2026 - 08:38:32 EST


On 10/2/26 5:22 PM, Nilay Shroff wrote:
> The earlier fail_if_no_path name came from the dm-multipath policy, which
> uses the same name for a similar use case. However, I agree that
> fail_if_no_path could be misleading here since it sounds like the inverse
> of QUEUE_IF_NO_PATH.
>
> So I'd vote for fail_on_ctrl_loss for this change.

Thanks both. We have consensus, so I'll send a v5 with the rename:
the attribute, the NVME_NSHEAD flag, the ABI entry, and all references
become fail_on_ctrl_loss / NVME_NSHEAD_FAIL_ON_CTRL_LOSS. No logic
changes otherwise, and I'll carry the Reviewed-by tags on patch 1.

Cheers,
Krishna