Re: [PATCH v5 00/15] nova-core: GPU interrupt support and GSP event delivery

[Alexandre Courbot]

On Tue, 29 Sep 2026 20:41:33 -0700, John Hubbard wrote:
> This series adds GPU interrupt support to nova-core, so that GSP events
> reach the driver as interrupts instead of only when the driver polls.
> v5 applies Alex's review of v4, and makes three of the design changes
> that he had set aside for after the merge. The series is 15 patches,
> down from 17. The two rust/ patches are unchanged.
> 
> GIN, the GPU Interrupt and Notification unit, is the GPU's interrupt
> controller, and it latches pending interrupts in a two-level register
> tree. TOP, the tree's top-level enable register, holds one enable bit
> per subtree.
> 
> [...]

Applied to drm-rust-next, thanks!

[01/15] rust: pci: declare IrqType and IrqTypes with impl_flags
        commit: 38c9764d330dfe1d59009179904e313b0923f7b4
[03/15] gpu: nova-core: add the GIN vector, leaf and subtree types
        commit: e6c579b496f2740c447d215ef868dc5f9cc7dc93
[04/15] gpu: nova-core: add the GIN CPU interrupt tree and MSI EOI registers
        [acourbot: keep item that doesn't need to be exported private.]
        commit: 2ef55e142d29970641e9be04897457bb98a8eaca
[05/15] gpu: nova-core: add the per-architecture GIN CPU interrupt HAL
        commit: 4022bcaa34e2115e175f6a64022ec19a186b0d72
[06/15] gpu: nova-core: add the GIN interrupt tree and allocate its vectors
        commit: 939b40877cb883de1fa335e950ff1a3f3bf113ed
[07/15] gpu: nova-core: wait for GFW boot in probe, not in the Gpu constructor
        [acourbot: move code to associated function, move relevant hunks to next
        patch.]
        commit: 94ddc4b4843da8b1858535b13318346cb950800d
[08/15] gpu: nova-core: add an interrupt delivery self-test
        [acourbot: move relevant bits of previous patch into this one.]
        [acourbot: remove reference to self-test section of documentation.]
        [acourbot: replace completions with atomic polling code.]
        commit: 9cb3f5d56e81fd97a82ef361b210bc2322daaaa7
[09/15] gpu: nova-core: log GSP events instead of discarding them
        commit: 0c551cdc465b9c99da33a21d6ee3b274cfda7006
[10/15] gpu: nova-core: return ENOMSG for an unmatched GSP message
        commit: d3cb3ed1a2ddd7cb77d9d270d82d3177ee744d1f
[11/15] gpu: nova-core: bound a GSP wait by a single deadline
        commit: 621b455c56376f5469d896b58c2316236a3f939d
[12/15] gpu: nova-core: add the falcon interrupt registers and HAL methods
        [acourbot: remove implementation-specific comments on interface doc.]
        [acourbot: make constructor take boolean instead of having two methods.]
        [acourbot: add NVIDIA copyright headers to modified files.]
        commit: e727d1c382a0cb2e10fd7aabef9217d1a37c80c7
[13/15] gpu: nova-core: service GSP events from the SWGEN0 interrupt
        [acourbot: trim comment leaking unneeded implementation details.]
        [acourbot: make Subtree crate-visible here instead of in earlier patch.]
        commit: 476abf9f669d87f993429ebb42668169464c907c
[14/15] gpu: nova-core: add KUnit tests for the interrupt tree
        commit: 306279ce974d396136544aa88027ee921ac09540
[15/15] gpu: nova-core: document the GIN interrupt controller and GSP events
        [acourbot: cut the last 3 sections.]
        commit: df718311a84188e26d499301c3921e4c392d557e