Re: [PATCH v5 15/15] gpu: nova-core: document the GIN interrupt controller and GSP events

From: Alexandre Courbot

Date: Fri Oct 02 2026 - 09:41:08 EST


On Wed Sep 30, 2026 at 12:41 PM JST, John Hubbard wrote:
> The interrupt code rests on hardware behavior that the code cannot show
> on its own: how GIN, the GPU's interrupt controller, records and
> delivers interrupts, what edge-triggered delivery requires of a handler,
> and how the GSP signals the CPU. Some of those requirements come from
> OpenRM rather than from the hardware manuals.
>
> Add a design document that records that behavior, the rules that
> nova-core follows because of it, and the terms that the code uses for
> it. The code comments cite the document by section rather than repeating
> it.
>
> Assisted-by: LLM
> Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
> ---
> Documentation/gpu/nova/core/interrupts.rst | 679 +++++++++++++++++++++
> Documentation/gpu/nova/index.rst | 1 +
> 2 files changed, 680 insertions(+)

I took the freedom to remove the last 3 paragraphs because they read
like filler and didn't provide any useful information. The self-test in
particular should be self-contained (and mostly is) and describing it at
length here carries the risk that the code will eventually diverge from
the doc.

But the rest was informative. Maybe we can give it another pass later to
smoothen it further, but even as-is the document is helpful imho.