[PATCH v2] misc: Kconfig: tc9564: fix and simplify dependencies
From: Alex Elder
Date: Fri Oct 02 2026 - 10:07:48 EST
The TC9564_PCI config option selects PCI_DYNAMIC_OF_NODES. But that
depends on OF_IRQ, and TC9564_PCI does not satisfy that dependency.
Simply adding "depends on OF_IRQ" results in a recursive Kconfig
dependency, so we need to satisfy it in a different way.
On the other hand, PCI_DYNAMIC_OF_NODES is a user-visible option and
should not be selected. So switch to depending on that rather than
selecting it.
PCI_DYNAMIC_OF_NODES already depends on OF_IRQ, so we no longer need
to depend on it directly. OF_IRQ is only exposed as an option if OF
is enabled, so OF_IRQ enabled implies OF is enabled.
Finally, PCI_DYNAMIC_OF_NODES is only exposed as an option if PCI is
enabled, so we can omit the dependency on PCI.
Therefore, depending on (rather than selecting) PCI_DYNAMIC_OF_NODES
satisfies the dependency on OF_IRQ, as well as on OF and PCI.
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202610020124.ieOiopjQ-lkp@xxxxxxxxx/
Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
Fixes: 1304b0c47ef81 ("misc: tc9564: introduce base PCI driver")
Signed-off-by: Alex Elder <elder@xxxxxxxxxxxx>
---
drivers/misc/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 9c5b1e9d672e8..6ae10ef8b3cc4 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -570,9 +570,7 @@ config MCHP_LAN966X_PCI
config TC9564_PCI
tristate "Toshiba TC9564 PCI function support"
- depends on OF
- depends on PCI
- select PCI_DYNAMIC_OF_NODES
+ depends on PCI_DYNAMIC_OF_NODES
select PCI_QUIRKS
default m
help
base-commit: 04434a1d0f311d76b1f15fa987918b471a0b8c6a
--
2.53.0