Re: [PATCH] misc: Kconfig: tc9564: fix a circular dependency

[Alex Elder]

On 10/2/26 7:55 AM, Arnd Bergmann wrote:
> On Fri, Oct 2, 2026, at 14:50, Alex Elder wrote:
> > On 10/2/26 1:02 AM, Arnd Bergmann wrote:
> > > On Fri, Oct 2, 2026, at 03:33, Alex Elder wrote:
> > > config TC9564_PCI
> > >    	tristate "Toshiba TC9564 PCI function support"
> > >           depends on PCI && PCI_DYNAMIC_OF_NODES && PCI_QUIRKS
> > >
> > > (in either one or three lines)
> >
> > If I do one, I'll combine OF and OF_IRQ similarly into one.
>
> If you have a dependency on PCI_DYNAMIC_OF_NODES, you don't
> need the extra dependency on OF_IRQ or OF.
>
> I guess you don't need the dependency on PCI either, unless
> we ever want to make PCI a tristate option have that in
> a loadable module.
>
>        Arnd

I'm partly influenced by something comparable to "include
what you use", where my instinct here would be to explicitly
indicate dependencies even if other depended-on config
options satisfy them.  But I'll do what you're suggesting.

I will omit the dependency on PCI.  This is the same situation
as the OF dependency, where OF_IRQ is only available if OF is
enabled.

I'm adding "Suggested-by" you in the commit, because the final
(much simpler) form derives directly from what you've said here.

Thank you.

					-Alex