Re: [RFC v6 1/3] workqueue: Simplify unbound sysfs attribute registration

[Tejun Heo]

Hello,

The following is a Claude-generated review.

On Thu, Oct 01, 2026 at 05:07:09PM +0100, Tvrtko Ursulin wrote:
> +static umode_t wq_sysfs_unbound_group_visible(struct kobject *kobj,
> +					      struct attribute *attr, int n)
> +{
> +	struct device *dev = kobj_to_dev(kobj);
> +	struct workqueue_struct *wq = dev_to_wq(dev);
> +
> +	if (!(wq->flags & WQ_UNBOUND))
> +		return SYSFS_GROUP_INVISIBLE;

SYSFS_GROUP_INVISIBLE is documented for named groups only. For an unnamed
group, fs/sysfs/group.c masks the bit off and the leftover 0 is what hides
the attribute. Can you return 0 here like wq_sysfs_is_visible() does?

Thanks.

--
tejun