Re: [PATCH 1/2] dt-bindings: hwmon: Add TI TPS389004/TPS389006/TPS389008

[Luna Hart]

On 10/1/26 1:17 AM, Krzysztof Kozlowski wrote:
> > +    const: 0
> > +
> > +patternProperties:
> > +  "^vmon@[0-7]$":
>
> How is this called for other devices? "channel"?

It looks like "channel" is most common (perhaps "input" would be valid
too, from the ti,ina3221).

The V2 patch set changes this to "channel".


> > +      If no child nodes are present, all channels will be exposed for>> +      monitoring. Otherwise, only the provided nodes will be created.
>
> That's a bit odd behavior. Is it expected for hwmon?

It seems not. Changing this in V2 to enable all channels by default.
Disabling channels by using the status prop explicitly instead.

--

Thank you for the quick response and review of these changes.

All other comments will be addressed in the V2 patch set, which I will
share as soon as possible.


Regards,

Luna Hart