Re: [PATCH v2 2/3] soundwire: qcom: add multi-master support

[Vinod Koul]

On 01-10-26, 12:06, Srinivas Kandagatla wrote:
> 
> 
> On 10/1/26 11:53 AM, Pierre-Louis Bossart wrote:
> > 
> >> @@ -192,6 +194,13 @@ struct qcom_swrm_ctrl {
> >>  	const unsigned int *reg_layout;
> >>  	void __iomem *mmio;
> >>  	struct reset_control *audio_cgcr;
> >> +	u8 num_lanes;
> >> +	bool is_dependent;
> >> +	struct qcom_swrm_ctrl *peer_ctrl;
> >> +	u8 peer_first_lane;
> >> +	u8 num_peer_lanes;
> >> +	bool is_primary;
> >> +	u32 peer_dpn_offset;
> > 
> > nit-pick: do you need both is_dependent and is_primary? One would think
> > that a single variable would be enough, no?
> I did try to do that which made the code bit confusing to read.

I am viewing it that both should be set always for this mode. Do you
have a case where it wont be the case..?

> > also without context it's hard to understand if lanes are independent in
> > terms of transport or not, not sure what 'peer' means in a multi-master
> > setup with a primary controller and N dependent ones? Code like this
> For now its one, but Yes, technically we could have more dependent ones,
> I wanted to keep the patchset simple and right now the only have one
> peer and i dont know if we have other setups with more dependent
> controrllers.

Lets add the logic when we have such scenarios and keep now for one peer.
Does Qualcomm roadmap envision more controllers?

-- 
~Vinod