Re: [PATCH] ALSA: hda/tas2781: Accept V1 calibration data without CRC

[Takashi Iwai]

On Thu, 01 Oct 2026 12:24:42 +0200,
Mohamed Yassine Jebabli via B4 Relay wrote:
> 
> From: Mohamed Yassine Jebabli <med.jebabli@xxxxxxxxx>
> 
> Some Lenovo BIOSes (e.g. Legion Pro 7 16IRX9H, SSID 17aa:38cd) store
> valid V1 calibration data in the CALI_DATA EFI variable but leave the
> TimeStamp and CRC fields zeroed. The driver rejects such data, so the
> amplifiers always run with default parameters on these machines.
> 
> The rejection was silent until
> commit 4fe238513407 ("ALSA: hda/tas2781: Move and unified the
> calibrated-data getting function for SPI and I2C into the tas2781_hda lib")
> turned it into "V1 CRC error".
> 
> The stored values are consistent (R0 = 3.82/3.83 ohm, 1/R0 matching
> within 1e-4), so accept V1 data when both TimeStamp and CRC are zero
> and the first device entry is non-zero, and emit a warning.
> 
> Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Mohamed Yassine Jebabli <med.jebabli@xxxxxxxxx>

Applied now.  Thanks.


Takashi