Re: [PATCH v4 0/4] KVM: arm64: fix VGICv3 redistributor rollback

[Marc Zyngier]

On Fri, 02 Oct 2026 18:45:21 +0100,
Karl Mehltretter <kmehltretter@xxxxxxxxx> wrote:
> 
> On Mon, Aug 31, 2026 at 10:10:00AM +0100, Karl Mehltretter wrote:
> > Changes since v3:
> > - Dropped the REDIST/REDIST_REGION serialization and VGIC init/destroy
> >   rework, keeping the fix close to v2. (Marc)
> > - Limited rollback to assignments from the new region so an older-region
> >   assignment cannot be missed during concurrent vCPU creation.
> > - Added Fuad's Reviewed-by tags to patches 1, 3 and 4. These are otherwise
> >   unchanged from v3 (formerly patches 1, 4 and 5).
> > 
> > Previous version:
> > v3: https://lore.kernel.org/r/20260822095346.53882-1-kmehltretter@xxxxxxxxx
> > 
> > Karl Mehltretter (4):
> >   KVM: arm64: vgic-v3: Undo assignment on iodev registration failure
> >   KVM: arm64: vgic-v3: Roll back assignments from the new region
> >   KVM: arm64: selftests: Pass guest code to vm_gic_create_with_vcpus()
> >   KVM: arm64: selftests: Test VGICv3 redistributor region retry
> > 
> >  arch/arm64/kvm/vgic/vgic-mmio-v3.c            |  54 ++++++--
> >  tools/testing/selftests/kvm/arm64/vgic_init.c | 116 ++++++++++++++++--
> >  2 files changed, 151 insertions(+), 19 deletions(-)
> 
> A friendly ping on v4. Patches 1, 3, and 4 have Fuad's Reviewed-by;
> patch 2 was revised following Marc's feedback.

The trouble is that we don't seem to agree on what "minimal changes"
means. I've applied these patches locally, and simplified the first
two patches to get rid of the superfluous helpers.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.