Re: [RFC PATCH] soc: aspeed: Add B650D4U power passthrough support

[Krzysztof Kozlowski]

On 02/10/2026 15:16, Prasanth Kumar Padarthi wrote:
> Add the AST2600 SCU passthrough selector support used by the
> ASRock Rack B650D4U host power-control circuit. This RFC includes
> the driver, Devicetree binding, and board node to discuss the final
> kernel-facing interface.
> 
> Signed-off-by: Prasanth Kumar Padarthi <prasanth.padarthi10@xxxxxxxxx>


Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

> ---
>  .../asrock,b650d4u-power-passthrough.yaml     |  23 ++++

Bindings for a driver is a no-go (for longer explanation see
writing-bindings, any tutorials or DTS101 slides).

>  .../dts/aspeed/aspeed-bmc-asrock-b650d4u.dts  |   5 +
>  drivers/soc/aspeed/Kconfig                    |   9 ++
>  drivers/soc/aspeed/Makefile                   |   1 +
>  drivers/soc/aspeed/aspeed-b650d4u-power.c     | 110 ++++++++++++++++++

Soc drivers should not expose user-space interfaces. Use existing
suitable subsystems.

Best regards,
Krzysztof