Re: [PATCH net v6 3/5] net: stmmac: Rename double VLAN references to svlan

From: Maxime Chevallier

Date: Sat Oct 03 2026 - 11:43:03 EST




On 10/2/26 10:37, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
>
> Low priority / nit picks for your consideration:
>
> - [Low] The self-test renamed to "SVLAN Filtering (perf)"
> (stmmac_test_svlanfilt_perfect), and likewise…

[...]

>
> This patch renames the test but keeps it in this state, and the
> remaining patches in the series do not touch the selftests. Should
> these two "(perf)" tests be reworked or dropped?

FWIW I'm ok with dropping the test. It's still in the history, and
if anyone is interested in bringing the VLAN perfect filter one day,
they can bring the tests back too.

Maxime