Re: [PATCH] lib: Move SipHash into lib/crypto/

[Eric Biggers]

On Sat, Oct 03, 2026 at 09:31:39AM +0200, Ard Biesheuvel wrote:
> 
> On Sat, 3 Oct 2026, at 05:49, Jason A. Donenfeld wrote:
> > On Fri, Oct 02, 2026 at 03:37:08PM -0700, Eric Biggers wrote:
> >> The addition of SipHash to lib/ predated the existence of the
> >> lib/crypto/ directory.  Since it's a cryptographic algorithm, move it
> >> from the top-level lib/ directory to lib/crypto/.
> >> 
> >> Specifically:
> >> 
> >> - Move both siphash.c and siphash_kunit.c.  Keep the header
> >>   <linux/siphash.h> as-is for now.
> >> 
> >> - Keep the dedicated MAINTAINERS entry for SipHash.  Just update the
> >>   file paths it references.
> >
> > Given that I'm also listed in the crypto section, I think we may as well
> > delete the whole separate entry.
> >
> > The only downside of this change is that those hsiphash functions are,
> > erm, a bit less than cryptographic-strength. But maybe such concerns
> > don't really matter any more at this stage, and we might as well group
> > it all in lib/crypto/ where it all belonged originally anyway.
> >
> > Acked-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
> >
> 
> Either works for me.
> 
> Acked-by: Ard Biesheuvel <ardb@xxxxxxxxxx>

Makes sense.  v2 removes the separate MAINTAINERS entry.

- Eric