Re: [PATCH] sh: sh7785lcr: register the PCA9564 as I2C bus 0

[John Paul Adrian Glaubitz]

Hi Geert,

On Sat, 2026-10-03 at 14:52 +0200, Geert Uytterhoeven wrote:
> Hi Karl,
> 
> On Sat, 3 Oct 2026 at 11:51, Karl Mehltretter <kmehltretter@xxxxxxxxx> wrote:
> > On Sat, Oct 03, 2026 at 11:38:43AM +0100, John Paul Adrian Glaubitz wrote:
> > > > Reviewed-by: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>
> > > 
> > > I have to admit though I don't fully understand the description of this
> > > patch. Either I don't have enough coffee or it's not precise enough.
> > 
> > Thanks for testing and reviewing! I agree the changelog doesn't explain
> > why -1 is wrong and 0 is right for this board very clearly. I'll give it
> > a day or so to step back and submit a v2 with your tags and a better
> > changelog.
> 
> Perhaps something like:
> 
> Before commit 44454baa7ca7bb57 ("i2c: Dynamically assign adapter id if
> it wasn't explictly specified"), a negative ID was replaced by zero,
> and I2C bus zero was instantiated.  Since that commit, a negative ID
> is passed verbatim, instantiating an I2C bus with a dynamic number.
> As SH boards still use i2c_register_board_info(0, ...) to register I2C
> devices, they rely on the I2C bus being bus zero, causing registration to fail.

Yeah, that makes a whole lot of more sense to me. Thanks for the clarification!

If Karl agrees, we can go with that one and he can send a v2.

Adrian

> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913