Re: [PATCH 1/2] dt-bindings: bus: Add binding for Altera AXI Timeout Bridge

[Krzysztof Kozlowski]

On 03/10/2026 22:19, Vyacheslav Yurkov via B4 Relay wrote:
> From: Vyacheslav Yurkov <V.Yurkov.EXT@xxxxxxxxxx>
> 
> Add a device tree binding for the Altera timeout bridge, which connects
> an Avalon bus to the HPS and provides an address space for child
> devices with a fall back to a simple bus.
> 
> Signed-off-by: Vyacheslav Yurkov <V.Yurkov.EXT@xxxxxxxxxx>
> ---
>  .../bindings/bus/altera-timeout-bridge.yaml        | 82 ++++++++++++++++++++++

Filename must match compatible and compatible has completely broken
format. Please look at DT spec or any other examples how compatibles are
created.


>  1 file changed, 82 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/bus/altera-timeout-bridge.yaml b/Documentation/devicetree/bindings/bus/altera-timeout-bridge.yaml
> new file mode 100644
> index 000000000000..b57a0966ba6e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bus/altera-timeout-bridge.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bus/altera-timeout-bridge.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Altera Timeout Bridge
> +
> +maintainers:
> +  - Vyacheslav Yurkov <V.Yurkov.EXT@xxxxxxxxxx>
> +
> +description: |
> +  Altera timeout bridge bus.

Useless description. You keep repeating the same.

> +
> +properties:
> +  compatible:
> +    items:
> +      - const: altera-timeout-bridge
> +      - const: simple-bus

Why the fallback?

Your commit msg is also useless here, you just wrote what you did, not why.

I see no reason why generic "bus" like that should stay generic,
although you have entire commit msg to explain why this is different or
what is the versioning of this IP block.

Missing blank line.

> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  ranges: true
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-parent
> +  - ranges
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +patternProperties:

This follows properties.

> +  "^[a-zA-Z][a-zA-Z0-9,+._-]*@[0-9a-f]+$":
> +    type: object
> +    description: |
> +      Device connected to the timeout bridge.
> +
> +    required:
> +      - compatible
> +      - reg
> +
> +    additionalProperties: true
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    intc: interrupt-controller {
> +        interrupt-controller;
> +        #interrupt-cells = <3>;
> +    };

Drop, irrelevant


> +
> +    timeout_bridge_hps@10000 {

Really, this is the style you send? So the toolset - dt-check-style - or
the Coding style mean nothing and you keep sending what you have in
downstream.



Best regards,
Krzysztof