Re: [PATCH v4 1/2] staging: media: atomisp: Remove pad_w and pad_h module parameters

[Sakari Ailus]

Hi Prajval,

On Tue, Jul 21, 2026 at 10:05:31PM +0530, Prajval Chaudhary wrote:
> Remove the 'pad_w' and 'pad_h' module parameters to prevent userspace
> from overriding internal ISP hardware padding boundaries. Convert them
> into internal driver constants instead.
> 
> Signed-off-by: Prajval Chaudhary <prajvalchaudhari733@xxxxxxxxx>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_common.h | 4 ++--
>  drivers/staging/media/atomisp/pci/atomisp_v4l2.c   | 8 ++------
>  2 files changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_common.h b/drivers/staging/media/atomisp/pci/atomisp_common.h
> index a2462fc306fb..7c6c0124ff72 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_common.h
> +++ b/drivers/staging/media/atomisp/pci/atomisp_common.h
> @@ -22,8 +22,8 @@
>  
>  extern int dbg_level;
>  extern int dbg_func;
> -extern int pad_w;
> -extern int pad_h;
> +extern const int pad_w;
> +extern const int pad_h;

Please switch to macros while at it, with an appropriate prefix, e.g.
ATOMISP_PAD_[WH].

>  
>  /* Minimum padding requirements for ISP2400 (BYT) */
>  #define ISP2400_MIN_PAD_W		12
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> index 812230397409..d117fea2860c 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> @@ -64,13 +64,9 @@ MODULE_PARM_DESC(dbg_func,
>   * output res, and isp output res. however since we do not have this yet,
>   * the chosen solution is the next best thing.
>   */
> -int pad_w = 16;
> -module_param(pad_w, int, 0644);
> -MODULE_PARM_DESC(pad_w, "extra data for ISP processing");
> +const int pad_w = 16;
>  
> -int pad_h = 16;
> -module_param(pad_h, int, 0644);
> -MODULE_PARM_DESC(pad_h, "extra data for ISP processing");
> +const int pad_h = 16;
>  
>  /*
>   * FIXME: this is a hack to make easier to support ISP2401 variant.

-- 
Regards,

Sakari Ailus