Re: [PATCH v2] x86/mce: Do not treat cache hierarchy errors as memory errors

From: Borislav Petkov

Date: Sat Oct 03 2026 - 19:17:38 EST


On Sun, Oct 04, 2026 at 12:20:12AM +0200, Adrian Schlegel wrote:
> On Intel and Zhaoxin, mce_is_memory_error() returns true not only for memory controller errors but also for cache hierarchy errors (MCACOD 000F 0001 RRRR TTLL) and generic cache hierarchy errors (000F 0000 0000 11LL). The cache hierarchy checks were added in commit fa92c5869426 ("x86, mce: Support memory error recovery for both UCNA and Deferred error in machine_check_poll") for uncorrected errors. All callers of mce_is_memory_error() expect it to report memory errors only, as its name says.
>

$ cat /tmp/new | ./scripts/checkpatch.pl
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#14:
On Intel and Zhaoxin, mce_is_memory_error() returns true not only for memory controller errors but also for cache hierarchy errors (MCACOD 000F 0001 RRRR TTLL) and generic cache hierarchy errors (000F 0000 0000 11LL). The cache hierarchy checks were added in commit fa92c5869426 ("x86, mce: Support memory error recovery for both UCNA and Deferred error in machine_check_poll") for uncorrected errors. All callers of mce_is_memory_error() expect it to report memory errors only, as its name says.

total: 0 errors, 1 warnings, 23 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH v2] x86/mce: Do not treat cache hierarchy errors as memory" has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


do a

git log arch/x86/kernel/cpu/mce/core.c

to get inspired about how patches should look like.

Also:

https://docs.kernel.org/process/submitting-patches.html

and

https://docs.kernel.org/process/maintainer-tip.html

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette