Re: [PATCH RFC 3/9] lib/lz4: add the build environment for the vendored sources

[Michal Wilczynski]

On 9/28/26 07:48, Sergey Senozhatsky wrote:
> On (26/09/25 13:27), Michal Wilczynski wrote:
> [..]
>> +
>> +/* LZ4_decompress_fast() and LZ4_resetStream() are still kernel API. */
>> +#define LZ4_DISABLE_DEPRECATE_WARNINGS 1
> 
> Is this upstream code?  As far as I understand it, LZ4_decompress_fast*()
> deprecated upstream and are strongly discouraged.  Do we want to suppress
> deprecation warnings?
> 

It's ours lz4_deps.h but upstream's lz4.c sets the same switch for
itself lz4.c, since its own code calls deprecated functions. We
include lz4.h before lz4.c, so we have to set it first.

I agree on the direction. The only in-tree _fast() user is the pre boot
path of lib/decompress_unlz4.c, so as a follow-up I'd move it to
LZ4_decompress_safe_partial() and drop the three _fast exports.

Best regards,
-- 
Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>