Re: [PATCH 1/4] gpio: realtek-otto: Handle errors from optional IRQ lookup
From: Bui Duc Phuc
Date: Sat Oct 03 2026 - 21:08:38 EST
Hi Andy,
Thank you for pointing me to the discussion.
>
> Have you read the discussion [1]?
> It would be better to make platform_get_irq_optional() to be actually optional.
>
> [1]: https://lore.kernel.org/lkml/20220212201631.12648-1-s.shtylyov@xxxxxx/
>
However, Regardless of how the API might be redesigned in the future
to return 0
or negative error codes, the fundamental requirement at the driver
level remains
the same: real errors must be propagated properly.
This patch isn't concerned with the API style discussion, but rather
with ensuring
that driver probe doesn't silently swallow genuine errors like -EPROBE_DEFER.
Proper error reporting is necessary under any reasonable API design.
Best regards
Phuc