Re: [PATCH v5 1/6] dt-bindings: input: Add Himax HX83102J touchscreen

[Krzysztof Kozlowski]

On Sat, Oct 03, 2026 at 04:27:36PM +0200, Michał Kopeć wrote:
> From: Allen_Lin <allencl_lin@xxxxxxxxxxx>
> 
> Add the binding for the touch function of the Himax HX83102J, a touch
> and display driver integrated (TDDI) controller. The touch function is
> connected over SPI and shares the analog supplies and the reset of the
> display function, so it is powered and reset together with the panel
> and has to follow it.
> 
> Signed-off-by: Allen_Lin <allencl_lin@xxxxxxxxxxx>

Please use full name, not login or nickname. I see original patchset had
the same issue, but full name was provided in the maintainers entry. If
the original author does not want to fix that, you can takeover the
patchset.


> [michal@nozomi.space: rename ddreset-gpios to display-reset-gpios,
>  describe the shared supplies and the display reset, take over
>  maintainership, drop Rob's Reviewed-by because of these changes]
> Signed-off-by: Michał Kopeć <michal@nozomi.space>
> ---
>  .../input/touchscreen/himax,hx83102j.yaml     | 98 +++++++++++++++++++
>  MAINTAINERS                                   |  6 ++
>  2 files changed, 104 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml
> new file mode 100644
> index 0000000000000..c9f229bf9ca7b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/himax,hx83102j.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Himax hx83102j touchscreen
> +
> +maintainers:
> +  - Michał Kopeć <michal@nozomi.space>
> +
> +description:
> +  The Himax HX83102J is a touch and display driver integrated (TDDI)
> +  controller. Its touch function is connected over SPI and reports HID
> +  packets. The display and touch functions share the analog supplies and
> +  the display reset, so the touch function is powered and reset together
> +  with the panel it is part of.
> +
> +allOf:
> +  - $ref: /schemas/input/touchscreen/touchscreen.yaml#
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> +  compatible:
> +    const: himax,hx83102j
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1

You need description to explain why this is different than
display-reset-gpios.

> +
> +  vccd-supply:
> +    description: Digital I/O supply of the touch function.
> +
> +  vsn-supply:
> +    description: Negative analog supply, shared with the display function.
> +
> +  vsp-supply:
> +    description: Positive analog supply, shared with the display function.

Best regards,
Krzysztof