Re: [PATCH v1 3/5] gpio: Move Intel PCH type of GPIO drivers to the intel subfolder

[Andy Shevchenko]

On Sun, Oct 04, 2026 at 05:48:09AM +0000, Junjie Cao wrote:

> One small note: moving GPIO_ICH under "if PCI"
> also excludes its existing COMPILE_TEST &&
> HAS_IOPORT path when PCI=n.
> 
> I checked that gpio-ich.o builds with W=1 in that
> configuration before the move. Could we keep
> GPIO_ICH outside the PCI conditional to preserve
> that coverage?

For what purpose? Yes, it might compile with PCI=n, but it makes no functional
sense. Note, that currently Kconfig puts (mistakenly!) this driver as memory
mapped GPIO driver, which is true, but not the whole picture. This is part of
MFD driver, that is solely PCI and never been anything else. My series rectifies
(or, if you wish, clarifies) this.

Also note, that having compile test enabled on PCI devices with PCI=n may lead
to build issues as PCI doesn't have full set of stubs (yet?). It's not directly
related to _this_ driver, but MFD parent one might be the case.

But, of course, it's not a big deal to add " || COMPILE_TEST" to that "if PCI".
I will consider doing that if we move forward with this series at all. Currently
there is no consensus on what to do with some drivers.

-- 
With Best Regards,
Andy Shevchenko