Re: [PATCH] media: rc: Fix simulated TX timer lifecycle

From: Runyu Xiao

Date: Sun Oct 04 2026 - 05:45:48 EST


Hi Sean,

Thanks for the review.

On Tue, Sep 29, 2026 at 05:20:25PM +0100, Sean Young wrote:
> I think this patch is correct, but I am not sure txsim is really needed
> in the source code. Maybe it's better to just remove txsim module parameter
> and all related code.

The txsim parameter enables the driver to expose TX on hardware without
native TX support by simulating TX completion. I found no in-tree references
outside ene_ir.c and no separate documentation for txsim. Removing it would
drop that fallback. Do you consider this fallback obsolete and prefer
removing it in this change? If so, I can revise the patch to remove txsim and
its related code; otherwise, I will keep the timer-lifecycle fix separate
from that cleanup.

Thanks,
Runyu