Re: [PATCH v2] mm/vmalloc: bail out early on invalid page_shift in __vmap_pages_range_noflush()

From: Vishal Moola (Fractile)

Date: Sun Oct 04 2026 - 09:55:34 EST


On Sun, Oct 04, 2026 at 03:16:39PM +0800, Wen Jiang wrote:
> From: Wen Jiang <jiangwen6@xxxxxxxxxx>
>
> __vmap_pages_range_noflush() currently only warns when page_shift is
> smaller than PAGE_SHIFT, then continues with the invalid shift. Return
> -EINVAL instead so the bogus argument is caught immediately.
>
> Suggested-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
> Signed-off-by: Wen Jiang <jiangwen6@xxxxxxxxxx>
> Reviewed-by: Barry Song <baohua@xxxxxxxxxx>
> Reviewed-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>

Reviewed-by: Vishal Moola (Fractile) <vishal.moola@xxxxxxxxx>