Re: [PATCH] i2c: qcom-geni: release runtime PM reference when set_rate fails

From: Andi Shyti

Date: Sun Oct 04 2026 - 10:08:37 EST


Hi Rahul,

On Wed, Sep 30, 2026 at 04:46:41PM +0530, Rahul Pon wrote:
> geni_i2c_xfer() takes a runtime-PM reference with pm_runtime_get_sync()
> and then returns directly if the set_rate() callback fails, leaking the
> reference and keeping the controller resumed for good. Route that error
> through the existing cleanup path, which drops the reference and resets
> the transfer state.
>
> Found by code review; compile-tested with arm64 defconfig plus ACPI and
> W=1.
>
> Fixes: 10e74f4c5046 ("i2c: qcom-geni: Enable I2C on SA8255p Qualcomm platforms")
> Assisted-by: LLM
> Signed-off-by: Rahul Pon <theflyingrahul@xxxxxxxxx>

pushed to i2c/i2c-fixes-2.

Thanks,
Andi