Re: [PATCH] perf/arm-smmuv3: Propagate errors from optional IRQ lookup
From: Will Deacon
Date: Sun Oct 04 2026 - 10:42:42 EST
On Sun, Oct 04, 2026 at 08:49:07PM +0700, Bui Duc Phuc wrote:
> > Sorry, but how is failing the probe possibly better than continuing without
> > the optional interrupt? Add a diagnostic if you like, but aborting the probe
> > feels completely unnecessary to me.
> >
>
> My understanding is that the driver is designed to be generic and
> support various hardware configurations, some with this resource (IRQ,
> GPIO, clock, ...) and some without.
>
> If a configuration describes the resource, it means the board is
> designed to use it. For that hardware the "optional" nature of the
> driver no longer applies, so if we fail to get the resource the error
> should be returned.
>
> A log alone is easy to miss, and the root cause still has to be found
> and fixed later anyway. Failing the probe makes the problem visible
> right away, when the board is being brought up.
If you're doing bring-up, you should probably pay attention to the logs.
If you're trying to use the device, you probably don't care about the
interrupt.
Will