Re: [PATCH 4/7] sparc64: add SPARC64 VII CPU, MMU and SMP support

[Magnus Lindholm]

Hi Krzysztof,

On Sun, Oct 4, 2026 at 4:59 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 02/10/2026 18:14, Magnus Lindholm wrote:
> > diff --git a/arch/sparc/kernel/prom_64.c b/arch/sparc/kernel/prom_64.c
> > index aa4799cbb9c1..11437bbfc73b 100644
> > --- a/arch/sparc/kernel/prom_64.c
> > +++ b/arch/sparc/kernel/prom_64.c
> > @@ -564,6 +564,12 @@ static void *fill_in_one_cpu(struct device_node *dp, int cpuid, int arg)
> >
> >               cpu_data(cpuid).core_id = portid + 1;
> >               cpu_data(cpuid).proc_id = portid;
> > +             if (tlb_type == sparc64_vii &&
> > +                 of_property_match_string(of_root, "model", "IKKAKU") >= 0) {
>
> Are the values documented as ABI anywhere? Usually the compatible is the
> ABI, not the model.
>
Thanks alot for taking the time to review this.

I haven't found documentation guaranteeing "IKKAKU" as an ABI;
the match came from this machine's firmware properties. Its root
node has no compatible property, although the core nodes advertise
"FJSV,SPARC64-VII+".

The firmware also describes the cmp/core/cpu hierarchy. I'll look
at deriving the topology from that instead of relying on the model
string and hard-coded CPU-ID layout.

> > +                     /* IKKAKU: two adjacent ITIDs per physical core. */
> > +                     cpu_data(cpuid).core_id = (cpuid >> 1) + 1;
> > +                     cpu_data(cpuid).proc_id = 0;
> > +             }

Regards,

Magnus