Re: [PATCH v2 1/8] irqchip/al-fic: fix argument alignment and a repeated word

[Radu Rendec]

On Sun, 2026-09-27 at 08:06 +0000, Eliav Farber wrote:
> The continuation lines of the irq_domain_create_linear() call sit three
> columns short of the open parenthesis. They were aligned for
> irq_domain_add_linear(); commit affdc0d1bdfa ("irqchip: Switch to
> irq_domain_create_*()") renamed the function to one three characters longer
> and left the indentation as it was. checkpatch --strict reports "Alignment
> should match open parenthesis".
> 
> al_fic_wire_init()'s kernel-doc reads "the fic hardware to to work in wire
> mode". checkpatch reports "Possible repeated word: 'to'".
> 
> No functional change.
> 
> Signed-off-by: Eliav Farber <farbere@xxxxxxxxxx>
> ---
> v2: new patch. checkpatch --strict cleanups (argument alignment and a
>     repeated word) split out ahead of the functional changes; the touched
>     lines also appear as context in patches 3 and 6.
> 
>  drivers/irqchip/irq-al-fic.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-al-fic.c b/drivers/irqchip/irq-al-fic.c
> index d10ac9b63c99..35581332b40e 100644
> --- a/drivers/irqchip/irq-al-fic.c
> +++ b/drivers/irqchip/irq-al-fic.c
> @@ -132,9 +132,9 @@ static int al_fic_register(struct device_node *node,
>  	int ret;
>  
>  	fic->domain = irq_domain_create_linear(of_fwnode_handle(node),
> -					    NR_FIC_IRQS,
> -					    &irq_generic_chip_ops,
> -					    fic);
> +					       NR_FIC_IRQS,
> +					       &irq_generic_chip_ops,
> +					       fic);
>  	if (!fic->domain) {
>  		pr_err("fail to add irq domain\n");
>  		return -ENOMEM;
> @@ -180,7 +180,7 @@ static int al_fic_register(struct device_node *node,
>   * @name: name of the fic
>   * @parent_irq: interrupt of parent
>   *
> - * This API will configure the fic hardware to to work in wire mode.
> + * This API will configure the fic hardware to work in wire mode.
>   * In wire mode, fic hardware is generating a wire ("wired") interrupt.
>   * Interrupt can be generated based on positive edge or level - configuration is
>   * to be determined based on connected hardware to this fic.

Reviewed-by: Radu Rendec <radu@xxxxxxxxxx>