Re: [PATCH RESEND] power: supply: bq24190_charger: don't reset registers across system suspend
From: Sebastian Reichel
Date: Sun Oct 04 2026 - 13:47:44 EST
On Mon, 28 Sep 2026 17:26:17 -0500, Ryan Brue wrote:
> bq24190_pm_suspend() calls bq24190_register_reset(), which returns every
> register to its power-on default, and bq24190_pm_resume() does it again
> before re-applying the probe-time configuration. On any board that wires
> the charger's interrupt this makes system suspend unusable.
>
> The reset re-arms the chip's 40 s i2c watchdog. bq24190_set_config() turns
> that watchdog off at probe, deliberately: as the comment there explains,
> the same write also takes the part out of default mode into host mode.
> Nothing pets it while the system is asleep, so it expires, resets the
> registers again and pulses INT. The charger interrupt is a system wake
> source -- armed unconditionally in probe since commit f385e6e2a153 ("power:
> bq24190_charger: Use PM runtime autosuspend"), and still enabled by default
> after the conversion to the wake irq API [1] -- so the pulse wakes the
> machine.
>
> [...]
Applied, thanks!
[1/1] power: supply: bq24190_charger: don't reset registers across system suspend
commit: e0844bd22a9f97885882bde3c4a441710e895240
Best regards,
--
Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>