Re: [PATCH] staging: rtl8723bs: remove dead antenna diversity infrastructure (FAT/SWAT)

[Marinela Tatiana Selseth]

Hi Greg,

Thank you for the review.

Regarding the "deep analysis" phrasing: I apologize for the loose and
exaggerated wording in the description. For this cleanup, I did manual
code tracking via grep to isolate the unwritten members.
I will simplify this wording in a v2 commit.

Regarding testing on real hardware to see if the rtw_read32() dummy
read can be dropped: I do not have access to a physical RTL8723BS
SDIO card on my local architecture. This commit has been verified
through static source exploration and compilation checks only.

Because clearing low-level register reads without an active hardware
test loop risks breaking chip initialization timing or clearing
hardware latch states, I opted to preserve the dummy read out of an
abundance of caution for stability.

In case someone in the community with access to the real hardware is
able to test dropping this register read, I can then remove the line,
or they can.

Best regards,
Marinela Selseth