Re: [PATCH] platform/chrome: cros_usbpd_notify: Don't use a non-EC parent's drvdata

[Tzung-Bi Shih]

On Sat, Oct 03, 2026 at 01:46:23PM -0700, Sergey Tiraspolsky wrote:
> Notes:
>     Tested on a 2017 Google Pixelbook (Eve), where GOOG0003 is a child of
>     PNP0C09, on 7.2.5 (Arch-based distro kernel; none of its patches touch
>     drivers/platform/chrome or drivers/acpi/ec.c), building this change as
>     an out-of-tree module:
>     
>      - without the patch: four oopses with the trace above in the logs, one
>        3 seconds after resume, and lid-close suspends that never resumed
>      - with the patch: the probe prints "Couldn't get Chrome EC device
>        pointer." again; a charger unplug/replug produced 9 USB PD
>        notifications, all taking the "EC device inaccessible; sending 0
>        event status" path; suspend with a charger unplug/replug while asleep
>        resumed normally; no oopses
>     
>     Not tested: a device where GOOG0003 is a child of GOOG0004 (that path
>     only moves into the if branch here, its logic is unchanged).

Hi Sergey,

Thanks for looking into this.

Coincidentally, James Fairweather ran into the same issue on a Nami
Chromebook and submitted a patch shortly after yours [1].

The patch [1] addresses the same crash, but also fixes an existing firmware
node reference leak by calling fwnode_handle_put() on the handle returned by
fwnode_get_parent().

Because of the additional leak fix, I plan to proceed with James's patch.
To ensure your earlier report and testing on Eve are properly credited, I'll
add your "Reported-by" tag when applying the patch.

If you have a chance to test James's patch on your Pixelbook (Eve) and reply
with a Tested-by tag to [1], that would be greatly appreciated.

[1] https://lore.kernel.org/all/20261003222855.23707-1-james.a.fairweather@xxxxxxxxx/