Re: [PATCH v2 02/15] PCI: rcar-gen4: Check live link status in link_up()

[Marek Vasut]

On 10/5/26 6:22 AM, Koichiro Den wrote:

Hello Den-san,

> > > I apologize for the late reply.
> > >
> > > Reviewed-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> > > Tested-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx> # R-Car V4H
>
> Thanks for the review and for testing on V4H.
>
> > > Since next 20261002 now contains commit
> > >
> > > f29719b5064c ("PCI: dwc: Align register macros with Synopsys
> > > documentation")
> > >
> > > This will need the following slight adjustment:
> > >
> > > "s@PCIE_PORT_DEBUG@PORT_LINK_DEBUG@g"
> > >
> > > "
> > > -       val = dw_pcie_readl_dbi(dw, PCIE_PORT_DEBUG1);
> > > -       return (val & PCIE_PORT_DEBUG1_LINK_UP) &&
> > > -              !(val & PCIE_PORT_DEBUG1_LINK_IN_TRAINING);
> > > +       val = dw_pcie_readl_dbi(dw, PORT_LINK_DEBUG1);
> > > +       return (val & PORT_LINK_DEBUG1_LINK_UP) &&
> > > +              !(val & PORT_LINK_DEBUG1_LINK_IN_TRAINING);
> > > "
>
> Thanks for the heads-up. v3 will be rebased onto the latest -next and use the
> new names.
>
> > A small nitpick, would the following change make sense to reduce duplication
> > a bit ?
>
> Yes. In v3 I'm planning to add it as a separate patch right before this one,
> with your Suggested-by.
Thank you !