Re: [PATCH] power: supply: cros_charge-control: restore EC state on resume

[Tzung-Bi Shih]

On Mon, Oct 05, 2026 at 03:44:45PM +1100, Andrew Pam wrote:
> On Mon, 5 Oct 2026, at 15:20, Tzung-Bi Shih wrote:
> > On Mon, Oct 05, 2026 at 09:56:06AM +1100, Andrew Pam wrote:
> > > Nothing notices the reset. Commit 4fc88ba435da ("power: supply:
> > > cros_charge-control: adopt EC charge state on probe") made the driver
> > 
> > The commit 4fc88ba435da doesn't exist.
> 
> Thanks for the review. The patch is against Sebastian's power-supply for-next, where that is Matt's patch you reviewed, applied on 10 September:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/commit/?id=4fc88ba435da
> 
> It isn't in mainline or chrome-platform yet, so I have made that explicit in the v2 commit message.
> 
> > > initialise its cached state from the EC, but it does so only on probe,
> >                               ^^^^
> > To be precise, this should be "to".
> 
> Reworded in v2 as "made the driver adopt the EC's charge state, but only at probe".

Ah, I see.  I misunderstood because the commit wasn't in my local tree.