RE: [PATCH] wifi: iwlwifi: mld: include VI packets in low latency detection

[Korenblit, Miriam Rachel]

> -----Original Message-----
> From: Endrik Einberg <git@xxxxxxxxxx>
> Sent: Monday, October 5, 2026 12:45 AM
> To: Korenblit, Miriam Rachel <miriam.rachel.korenblit@xxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Endrik Einberg <git@xxxxxxxxxx>
> Subject: [PATCH] wifi: iwlwifi: mld: include VI packets in low latency detection
> 
> iwl_mld_is_vo_vi_pkt() checks whether the mapped access category is less than
> IEEE80211_AC_VI.
> Since mac80211 defines IEEE80211_AC_VO as 0 and IEEE80211_AC_VI as 1, this
> only matches voice traffic and excludes video traffic.
> 
> Include IEEE80211_AC_VI as intended,
> matching behaviour of iwlmvm's iwl_mvm_calc_tcm_stats().
> 
> Fixes: d1e879ec600f ("wifi: iwlwifi: add iwlmld sub-driver")
> Signed-off-by: Endrik Einberg <git@xxxxxxxxxx>
> ---
>  drivers/net/wireless/intel/iwlwifi/mld/low_latency.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/mld/low_latency.c
> b/drivers/net/wireless/intel/iwlwifi/mld/low_latency.c
> index a4ddc32e2860..36da639aee54 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mld/low_latency.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mld/low_latency.c
> @@ -257,7 +257,7 @@ static bool iwl_mld_is_vo_vi_pkt(struct ieee80211_hdr
> *hdr)
>  	if (tid >= IWL_MAX_TID_COUNT)
>  		return false;
> 
> -	return tid_to_mac80211_ac[tid] < IEEE80211_AC_VI;
> +	return tid_to_mac80211_ac[tid] <= IEEE80211_AC_VI;

I don't want to rely on the value of the different enums too much.
Let's be explicit:
return tid_to_mac80211_ac[tid]  == IEEE80211_AC_VI ||
            tid_to_mac80211_ac[tid]  == IEEE80211_AC_VO
>  }
> 
>  void iwl_mld_low_latency_update_counters(struct iwl_mld *mld,
> --
> 2.53.0