Re: [PATCH v7 3/4] can: rx-offload: allow more than one receive source

[Marc Kleine-Budde]

On 03.10.2026 21:36:25, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 5 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 4 (2)
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] In can_rx_offload_move_to_skb_queue() the comment says the
>   sorted merge will 'keep the timestamp order over all sources', but it…

I've found some old downstream patch series that might solve the RX
starvation and continuous timestamp problem:

https://lore.kernel.org/all/20261005-upstream-can-rx-offload-batching-alternative-v1-0-4c08ccb516ec@xxxxxxxxxxxxxx/

The idea is to not flush the whole skb_irq_queue but only 3/4 of it.
Feel free to use ideas or the code in your series.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature