Re: [PATCH 5/5] ARM: dts: qcom: apq8064: Drop PCLK from static replicator

[Leo Yan]

On Fri, Oct 02, 2026 at 07:05:14PM +0300, Dmitry Baryshkov wrote:
> On Fri, Oct 02, 2026 at 04:33:28PM +0100, Leo Yan wrote:
> > On Fri, Oct 02, 2026 at 06:21:36PM +0300, Dmitry Baryshkov wrote:
> > > On Fri, Oct 02, 2026 at 04:07:24PM +0100, Leo Yan wrote:
> > > > The APQ8064 static replicator has no registers to program, so it
> > > > does not need an APB clock. Remove its RPM_QDSS_CLK reference.
> > > > Other programmable CoreSight devices keep their clock references.
> > > 
> > > QDSS clock is not actually the APB one, it's required for the coresight
> > > (or to access some of the regs) if I remember correctly.
> > 
> > If so, it might be atclk for clocking the module rather than the
> > register interface. Could you confirm this?
> > 
> > The replicator is just a middle component on the data path. I read
> > that it shares the same clock with other CoreSight components, so it
> > should still be safe to remove the clock from the replicator node,
> > as other components on the path will ensure that the clock is enabled.
> 
> Unfortunately it might be hard to find info for this platform nowadays. 

How about rename RPM_QDSS_CLK on the static replicator as "atclk", the
optional clock name supported by its binding.

          replicator {
                compatible = "arm,coresight-static-replicator";

                clocks = <&rpmcc RPM_QDSS_CLK>;
-               clock-names = "apb_pclk";
+               clock-names = "atclk";

I would leave the AMBA CoreSight nodes in the same dtsi unchanged for
now. They need an apb_pclk lookup for register access, and so far we
have no evidence to justify adding the same RPM clock again as atclk.

Please let me know if this works for you.

Thanks,
Leo