Re: [PATCH 1/1] x86/mm: fix incomplete page-table invalidation with TCE
From: Borislav Petkov
Date: Mon Oct 05 2026 - 10:54:33 EST
On Mon, Oct 05, 2026 at 10:36:26PM +0800, Lance Yang wrote:
> I don't have an AMD machine to test this on. I spotted something
> that looked wrong in the code and sent it out to see what others
> think.
You send a normal mail - not a patch.
> Maybe I'm reading the manual wrong, but is raising a concern
> based on the code and the manual really just "a wild hunch"?
If it is formulated like a patch which is supposed to be even urgent, then
you're reading our process wrong.
https://docs.kernel.org/process/development-process.html
And since you have not tested it to actually fix anything, then this patch is
nothing but a wild hunch.
And to answer your question, no, it is not needed. Definitely not the TCE
angle.
Now, the speculative thing is another story but that whole story you're
referring to needs a lot more debugging.
But we do not apply patches on a wild hunch, without any definitive data that
they fix an issue and, if very much possible, with a clear explanation why
they fix it.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette