Re: [PATCH v13 0/3] airoha: an7581: USB support
From: Christian Marangi (Ansuel)
Date: Mon Oct 05 2026 - 11:39:06 EST
Il giorno lun 5 ott 2026 alle ore 17:28 Vinod Koul <vkoul@xxxxxxxxxx>
ha scritto:
>
> On 05-10-26, 12:55, Christian Marangi wrote:
> > This is a major rework of the old v2 series.
> >
> > The SoC always support USB 2.0 but for USB 3.0 it needs additional
> > configuration for the Serdes port. Such port can be either configured
> > for USB usage or for PCIe lines or HSGMII and these are configured
> > in the SCU space.
> >
> > The previous implementation of a dedicated SSR driver was too
> > complex and fragile for the simple task of configuring a register
> > hence it was dropped and the handling is entirely in the PHY driver.
> >
> > Everything was reducted to the dt-bindings to describe the Serdes line.
> >
> > Also the property for the PHY are renamed to a more suitable name and
> > everything is now mandatory to simplify the implementation.
> > (the PHY are always present and active on the SoC)
> >
> > Also other unrelated patch are dropped from this series.
> >
> > Changes v13:
> > - Rebase on top of phy next
>
> Pls fix the chechpatch issues. There is new blank line at EOF, SPDX
> format mismatches and many more. Make sure you pass --strict flag to it
>
My checkpatch doesn't report the blank line. Am I missing something?
For SPDX, is it ok to change it? The commit just move file. I would
like to fix that in a separate commit after. (I can include in this
series if you
want)
The other warning are about Kconfig description where I can
artificially make the help text longer (no idea if it's OK...)
And the line too long for the define but making the line shorter
would result in a disaster for the register.
Up to you what I should fix but I guess the real important one
is the blank line but my checkpatch script is not detecting that...
Can you help?