Re: [PATCH] platform/x86: hp-bioscfg: consolidate common package-element parsing

From: Ilpo Järvinen

Date: Mon Oct 05 2026 - 11:42:53 EST


On Sun, 06 Sep 2026 02:48:01 +0500, Muhammad Bilal wrote:

> hp_populate_string_elements_from_package(),
> hp_populate_integer_elements_from_package(),
> hp_populate_enumeration_elements_from_package(),
> hp_populate_ordered_list_elements_from_package(), and
> hp_populate_password_elements_from_package() each parse the same
> PATH..SECURITY_LEVEL range into their own struct common_data
> sub-object, copy-pasted five times. Factor it into
> hp_get_common_data_from_package(), called from all five, mirroring
> hp_get_common_data_from_buffer()'s existing split for the buffer
> side.
>
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.

The list of commits applied:
[1/1] platform/x86: hp-bioscfg: consolidate common package-element parsing
commit: 4de5dc3bf805e96b41081d8001aaa416e4e58d98

--
i.