[PATCH 11/74] media: qcom: camss: Fix invalid declaration of PIX for SDM670
From: bod
Date: Mon Oct 05 2026 - 13:21:20 EST
From: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
line_num is declarative of the number and type of data-interfaces a VFE
has in CAMSS. The fourth line on full VFEs is reserved to the "PIX" path -
meaning the path that can do YUV, downscaling, stats, params or some
version of that.
In contrast the raw dump interfaces (RDI) 0, 1, 2 can only write
unformatted pixel-data and cannot generate stats.
The PIX path lives at a different register offset and has significantly
different setup to RDI.
VFE Lite has four RDI interfaces where VFE (full) has three RDI and one PIX
interface.
Unless/until PIX is actually implemented for SDM670 reduce line_num to
three to stop populating a pix path which simply isn't implemented.
Fixes: c52643b24152 ("media: qcom: camss: add support for SDM670 camss")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
---
drivers/media/platform/qcom/camss/camss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index 40a993ade5f6d..f46ad1db6dbbe 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -1202,7 +1202,7 @@ static const struct camss_subdev_resources vfe_res_670[] = {
.reg = { "vfe0" },
.interrupt = { "vfe0" },
.vfe = {
- .line_num = 4,
+ .line_num = 3,
.has_pd = true,
.pd_name = "ife0",
.hw_ops = &vfe_ops_170,
@@ -1224,7 +1224,7 @@ static const struct camss_subdev_resources vfe_res_670[] = {
.reg = { "vfe1" },
.interrupt = { "vfe1" },
.vfe = {
- .line_num = 4,
+ .line_num = 3,
.has_pd = true,
.pd_name = "ife1",
.hw_ops = &vfe_ops_170,
--
2.55.0