Re: [PATCH] platform/x86: asus-armoury: add power limits quirk for FA608UH

[Ilpo Järvinen]

On Sat, 19 Sep 2026, Marco Scardovi wrote:

> add power limits quirk entry for ASUS FA608UH laptop.
> The limits are extracted from the device's ThrottleGear XML configuration.
> 
> Signed-off-by: Marco Scardovi <scardracs@xxxxxxxxxxx>
> ---
>  drivers/platform/x86/asus-armoury.h | 31 changes(+/-)
>  1 file changed, 31 insertions(+), 0 deletions(-)
> 
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -713,6 +713,37 @@
>  			},
>  		},
>  	},
> +		{
> +			.matches = {
> +				DMI_MATCH(DMI_BOARD_NAME, "FA608UH"),
> +			},
> +			.driver_data = &(struct power_data) {
> +				.ac_data = &(struct power_limits) {
> +					.nv_dynamic_boost_max = 15,
> +					.nv_dynamic_boost_min = 10,
> +					.nv_temp_target_max = 87,
> +					.nv_temp_target_min = 75,
> +					.ppt_pl1_spl_max = 90,
> +					.ppt_pl1_spl_min = 15,
> +					.ppt_pl2_sppt_max = 90,
> +					.ppt_pl2_sppt_min = 35,
> +					.ppt_pl3_fppt_max = 90,
> +					.ppt_pl3_fppt_min = 35,
> +				},
> +				.dc_data = &(struct power_limits) {
> +					.nv_temp_target_max = 87,
> +					.nv_temp_target_min = 75,
> +					.ppt_pl1_spl_def = 45,
> +					.ppt_pl1_spl_max = 65,
> +					.ppt_pl1_spl_min = 15,
> +					.ppt_pl2_sppt_def = 54,
> +					.ppt_pl2_sppt_max = 65,
> +					.ppt_pl2_sppt_min = 35,
> +					.ppt_pl3_fppt_max = 65,
> +					.ppt_pl3_fppt_min = 35,
> +				},
> +			},
> +		},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_NAME, "FA608UM"),

Hi,

This won't work.

You're touching what is effectively the same place in the file in 
different patches that are not in a proper series, please don't do that.

If you're sending multiple of these next to each other, just make a proper 
series out of them, and if you have something pending I've not yet applied 
and end up needing to touch again the same place, send a new version of 
the existing series so I can just ignore the old one instead of having to 
figure out what's the correct order for applying things cleanly.

It's also much easier for me to apply 4 changes that are in a series than 
4 individual patches so as long as it's even remotely logical as a set of 
patches you should always prefer series over sending n individual patches 
to the same driver almost back to back.

I've stopped processing the remaining 4 entries and dropped them from my 
queue, please resend them as a series.

-- 
 i.