Re: [PATCH rtw-next v3 1/2] wifi: rtw88: download the beacon the reserved page was built with

From: Luka Gejak

Date: Mon Oct 05 2026 - 13:56:18 EST


October 5, 2026 at 16:35, "Mehmet Fide" <mehmet.fide@xxxxxxxxx mailto:mehmet.fide@xxxxxxxxx?to=%22Mehmet%20Fide%22%20%3Cmehmet.fide%40gmail.com%3E > wrote:


>
> From: Mehmet Fide <mehmet.fide@xxxxxxxxxxxxxxxxxx>
>
> rtw_fw_download_rsvd_page() downloads the beacon twice: once as part of
> the reserved page and once more on its own, so that the firmware ends up
> with a TX descriptor that describes the beacon rather than the whole
> page. The second download fetched a new beacon from mac80211 instead of
> downloading the one the page already holds.
>
> Besides the extra work, every beacon fetch advances the DTIM count and,
> while a channel switch is announced, the CSA countdown; doing it twice
> per update lets a countdown that starts at 2 reach 0, which mac80211
> warns about. Hand the beacon skb out of the page build and download
> that. The hw scan, which downloads the beacon without a page build,
> keeps fetching its own.
>
> Signed-off-by: Mehmet Fide <mehmet.fide@xxxxxxxxxxxxxxxxxx>
> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> ---

Patch 1 looks good to me.

Reviewed-by: Luka Gejak <luka.gejak@xxxxxxxxx>

Best regards,
Luka Gejak