Re: [PATCH 0/2] platform/x86/intel: power-domains: Handle failed tpmi_init()
From: Ilpo Järvinen
Date: Mon Oct 05 2026 - 14:53:31 EST
On Thu, 24 Sep 2026 12:36:23 -0700, Kristen Carlson Accardi wrote:
> tpmi_init() can fail before domain_die_map and tpmi_power_domain_mask
> are usable. It returns -ENODEV on CPU models that are not in
> tpmi_cpu_ids, before allocating them, and if cpuhp_setup_state() fails
> it frees them but leaves the pointers set. When the driver is built in,
> its exported helpers stay callable after either failure.
>
> Patch 1 fixes tpmi_get_linux_die_id(), which dereferences the NULL map.
> uncore-frequency-tpmi calls it when the world-readable die_id sysfs
> attribute is read, so on a multi-die CPU missing from tpmi_cpu_ids that
> read oopses.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.
The list of commits applied:
[1/2] platform/x86/intel: power-domains: Handle failed init in tpmi_get_linux_die_id()
commit: 14a9e1f5d57b3a9e6284d337c88d75ffb17f5869
[2/2] platform/x86/intel: power-domains: Handle failed init in tpmi_get_power_domain_mask()
commit: 371c7d7b4ed414c22744d5e275dd9b0c8f7052c4
--
i.