Re: [PATCH net-next v2] dt-bindings: net: Convert HiSilicon hns-dsaf to DT schema

[Rob Herring]

On Sun, Oct 04, 2026 at 10:15:37PM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 6 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 0 · Medium: 2 · Low: 4
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [Medium] The conversion drops the two leading legacy 'reg' regions
>   (sub-control and SerDes) that the old binding documented as the…

The old binding was deprecated for a long time and there are no users. 
Will detail in commit msg.

> - [Medium] The top-level 'required' list in hisilicon,hns-dsaf-v1.yaml
>   leaves out 'desc-num' and 'buf-size', although the deleted text…

Will fix.

> - [Low] The patch deletes
>   Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt, but…

Not an issue. Fixed when other binding is converted.

> - [Low] The deleted text binding had the buf-size and desc-num ranges
>   swapped ('buf-size: ... should be 16-1024', 'desc-num: ... should be…

Based on the .dts files and driver, the text binding is wrong.

> - [Low] The concern says that 'mc-mac-mask' with only 'maxItems: 6'
>   accepts 1–5 bytes, while hns_mac_get_info() needs exactly ETH_ALEN (6)…

Not an issue.

> - [Low] reg and reg-names use 'minItems: 1' for every 'mode'.

Not worth the complexity to try to express that.

pw-bot: cr

Rob