Re: [PATCH net-next] net: macb: move printk() calls out of bp->lock critical section

[Jakub Kicinski]

On Wed, 30 Sep 2026 20:55:47 +0200 Théo Lebrun wrote:
> >  - How the issue was discovered, e.g. hit in production, hit during
> >    development, syzbot report, manual code inspection, LLM or static
> >    analysis tool scan.  
> 
> This is mentioned two fold; in the commit message:
> 
>    The netconsole deadlock is theoretical & never reproduced.
> 
> And in the cover letter (folded below the '--' line):
> 
>    Technically it is a fix, in practice I'm happy for it to go through
>    net-next/main for more testing and it is a theoretical bugfix (as usual
>    nowadays). Decided after seeing Jakub taking a similar patch into
>    net-next this morning:

It's borderline, indeed. But "theoretical" does not tell us how you
stumbled upon this.

> - Maybe it could trust the driver maintainers, especially regarding the
>   second question about having access to real hardware?

I'd like it to keep asking. It's also useful to know which SoC you used
for testing. Of course this patch is quite trivial so the biggest
miss for the bot IMO is that it bothered looking at this patch in
the first place. Hard to tune these things :/